Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping Rule Class #1486

Open
PeterLombaers opened this issue Jul 6, 2023 · 2 comments
Open

Stopping Rule Class #1486

PeterLombaers opened this issue Jul 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@PeterLombaers
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe.
In simulation mode, when the simulation stops is based on arguments passed via the command line. The code is here.
It would be nice to have a class that implements the stopping rule, so that you can also make your own custom stopping rule plugin. This would allow simulating different stopping rules and comparing the performance.

Describe the solution you'd like
A class that implements a stop_review method which gets called at the end of every iteration of the simulation. You should be able to plug in a custom stopping rule class, similar to how you can plug in a model class.

@PeterLombaers PeterLombaers added the enhancement New feature or request label Jul 6, 2023
@J535D165
Copy link
Member

J535D165 commented Jul 6, 2023

Nice idea. A new entry point can be a nice solution. Any ideas on the design of this class?

@PeterLombaers PeterLombaers self-assigned this Jul 10, 2023
@Rensvandeschoot
Copy link
Member

Great idea!! This will open-up many new research directions!

linked to #557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants