Skip to content
This repository has been archived by the owner on Apr 11, 2020. It is now read-only.

RC2 File->New adds wrong GC section #505

Closed
benaadams opened this issue May 20, 2016 · 6 comments
Closed

RC2 File->New adds wrong GC section #505

benaadams opened this issue May 20, 2016 · 6 comments

Comments

@benaadams
Copy link

benaadams commented May 20, 2016

The templates add

"runtimeOptions": {
    "gcServer": true
}

However they should be adding

{
  "runtimeOptions": {
    "configProperties": {
      "System.GC.Server": true
    }
  }
}

As per all the aspnet samples and tests; the dotnet cli docs, and what happens when you run etc

See also https://github.com/dotnet/coreclr/issues/5117

@DamianEdwards
Copy link
Member

I don't think you have to set both do you? Only one of those should have any effect.

@benaadams
Copy link
Author

Sorry edited. Yeah the one in File->New which is gcServer has no effect.

All the aspnet repos already seem to use System.GC.Server

@benaadams
Copy link
Author

benaadams commented May 20, 2016

@DamianEdwards spent ages trying to work out why my plaintext throughput was terrible with RC2

@sayedihashimi
Copy link
Contributor

I have created a corresponding issue in the templates repo aspnet/Templates#575 to track getting the templates updated.

@benaadams
Copy link
Author

benaadams commented May 20, 2016

@sayedihashimi
Copy link
Contributor

Closing in favor of aspnet/Templates#575

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants