Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: upstream kafkajs instrumentation #263

Open
bnanda-appd opened this issue Jul 3, 2023 · 4 comments
Open

Request: upstream kafkajs instrumentation #263

bnanda-appd opened this issue Jul 3, 2023 · 4 comments

Comments

@bnanda-appd
Copy link

Can I request to add kafkajs instrumentation (opentelemetry-instrumentation-kafkajs) module to OpenTelemetry Meta Packages for Node (https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/metapackages/auto-instrumentations-node/README.md#supported-instrumentations).

A lot of users use kafkajs with node.js application in K8s and do not want to modify their source code or their application image with a tracing.js while instrumenting it with OpenTelemetry. The OpenTelemetry operator provides a way to achieve that. However it can instrument only the supported node.js packages mentioned at https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/metapackages/auto-instrumentations-node/README.md#supported-instrumentations.

As kafkajs is not included in the above list, there is no way to instrument kafka calls made by node.js using kafkajs framework. The only way to instrument such kafka call is to add a tracing.js into the application image and not use Opentelemetry operator to inject instrumentation. However, most of the times, it is a bit cumbersome.

@akubik-splunk
Copy link

Hey - we seem to have similar ask - there are a few instrumentations contained in this repo (e.g. elasticsearch, kafkajs, typeorm, sequelize...) that could be moved to corresponding OpenTelemetry js instrumentation modules. We (Splunk) would be willing to do the majority of the work as long the repo owners are ok with this

@mottibec
Copy link
Contributor

@akubik-splunk we started a process of moving all of the instrumentations over to the contrib repo.
After the Aspecto acquisition this was stopped, but we do want to upstream these. If Splunk is willing to help, this can really boost the effort, as currently no one actively maintains this repo.

@mottibec mottibec changed the title Request to add kafkajs instrumentation (opentelemetry-instrumentation-kafkajs) module to OpenTelemetry Meta Packages for Node (https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/metapackages/auto-instrumentations-node/README.md#supported-instrumentations). Request: upstream kafkajs instrumentation Jan 25, 2024
@akubik-splunk
Copy link

@akubik-splunk we started a process of moving all of the instrumentations over to the contrib repo. After the Aspecto acquisition this was stopped, but we do want to upstream these. If Splunk is willing to help, this can really boost the effort, as currently no one actively maintains this repo.

Hey
Thanks for context and clarification - yes we would like to help with this - I have already asked a few people contributing to JS to look into this. Hopefully soon some PRs will be created and we can coordinate around that or if You feel something more is necessary let me know. Thanks!

@mottibec
Copy link
Contributor

@akubik-splunk check out instrumentation-migration.md this might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants