New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequelize: Suggest better regex for opentelemetry-instrumentation-sequelize/utils.js extractTableFromQuery #253

Open

ray58750034 opened this issue Dec 29, 2022 · 0 comments

ray58750034 commented Dec 29, 2022 •

edited

Original code: https://github.com/aspecto-io/opentelemetry-ext-js/blob/master/packages/instrumentation-sequelize/src/utils.ts#L3

Suggest regex:

query.match(/(?<=(update|(?<!distinct\s+)from|join|truncate|into)\s+)\"?\`?(\w+)\"?\`?/gi);

Expect to work with following sqls:

UPDATE tableName SET field=value;
INSERT INTO tableName ("field") VALUES (value);
SELECT * FROM tableName WHERE field IS DISTINCT FROM value;

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment