Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket.io: connection should be a reserved event #153

Open
rauno56 opened this issue Jul 9, 2021 · 2 comments
Open

Socket.io: connection should be a reserved event #153

rauno56 opened this issue Jul 9, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@rauno56
Copy link
Collaborator

rauno56 commented Jul 9, 2021

See socketio/socket.io-website#277

The docs don't say that and maybe the maintainers have a good reason here, but, conceptually, if disconnect and disconnecting are reserved, so is connection.
@mottibec
Copy link
Contributor

mottibec commented Jul 12, 2021 •
edited

If I understood this conversation correctly, potentially, a client could emit a connection event.
So we should treat the connection as a reserved event only when instrumenting the Server instance and not the Socket.

@blumamir
Copy link
Contributor

and looks like we need to also treat new_namespace as reserved for the Server, right?

@blumamir blumamir added the good first issue Good for newcomers label Jul 13, 2021
@blumamir blumamir changed the title connection should be a reserved event Socket.io: connection should be a reserved event Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rauno56 @blumamir @mottibec