Explanation of buttons (on hover?)

[antonio1475]

Currently, the buttons in the automations list aren't self-explanatory:

I would expect at least a description on mouse hover over the icons. I really don't know what clicking each button will do.

[asosnovsky]

That's a good idea. I'll try to add something on my next round of UI improvements!

[asosnovsky]

Take a look at the new release v0.6.1

[chrisduma]

Hello i would like to contribute to the description on the buttons on hover

[asosnovsky]

Hi @ChrizDuma I've already implemented a hover over for this in the last release.

But take a look at this on getting the dev stack up https://github.com/asosnovsky/Shortumation/wiki/Development and this for any issues I think are easy starts https://github.com/asosnovsky/Shortumation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Will appreciate all the help :)

[asosnovsky]

@ChrizDuma if you still want to help, this issue here is a good starter! #146

you basically need to add a validator and cast it's type here https://github.com/asosnovsky/Shortumation/tree/main/webapp/src/types

then you need a sun editor condition node here https://github.com/asosnovsky/Shortumation/tree/main/webapp/src/components/ConditionEditor

e.g. trigger editor

Shortumation/webapp/src/components/ConditionEditor/editorRender.tsx

Lines 387 to 406 in 416d88b

	export const TriggerEditor: Editor<TriggerCondition> = ({
	onChange,
	condition,
	langStore,
	}) => {
	return (
	<>
	<InputText
	label={langStore.get("TRIGGER_ID")}
	value={condition.id}
	onChange={(id) =>
	onChange({
	...condition,
	id,
	})
	}
	/>
	</>
	);
	};

then add sun as an option here

Shortumation/webapp/src/utils/automations.ts

Lines 55 to 67 in 416d88b

	case "condition":
	return [
	"or",
	"and",
	"not",
	"state",
	"device",
	"numeric_state",
	"template",
	"time",
	"trigger",
	"zone",
	] as AutomationNodeSubtype<"condition">[];

I would do this, but I am trying to get a few other things implemented first XD

fyi, for visual testing create a storybook for sun condition here
https://github.com/asosnovsky/Shortumation/blob/416d88b965db3e562c0b07f5be06adb584005148/webapp/src/components/ConditionEditor/ConditionNodeBase.stories.tsx

Any help is a great help :D

[chrisduma]

if i may ask before proceeding, what language did you write this code in On Monday, August 29, 2022 at 07:56:48 PM GMT+3, Ari Sosnovsky ***@***.***> wrote: @ChrizDuma if you want this issue here is a good starter #146 you basically need to add a validator and cast it's type here https://github.com/asosnovsky/Shortumation/tree/main/webapp/src/types then you need a sun editor condition node here https://github.com/asosnovsky/Shortumation/tree/main/webapp/src/components/ConditionEditor then add sun as an option here https://github.com/asosnovsky/Shortumation/blob/416d88b965db3e562c0b07f5be06adb584005148/webapp/src/utils/automations.ts#L56 I would do this, but I am trying to get a few other things implemented first XD fyi, for visual testing create a storybook for sun condition here https://github.com/asosnovsky/Shortumation/blob/416d88b965db3e562c0b07f5be06adb584005148/webapp/src/components/ConditionEditor/ConditionNodeBase.stories.tsx — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[asosnovsky]

@ChrizDuma Typescirpt+React for the UI, python for the backend, please see https://github.com/asosnovsky/Shortumation/wiki/Development#prequesites