feat: create an argument captor #375
Conversation
|
I wasn't sure where to put the new code, so I put it at the end of The example in the rustdoc effectively acts as a test suite (it exercises all code paths). I'll address the build errors ASAP. |
| @@ -1142,6 +1142,8 @@ use std::{ | |||
| atomic::{AtomicUsize, Ordering} | |||
| }, | |||
| }; | |||
| use std::fmt::Display; | |||
There was a problem hiding this comment.
You can combine these use statements with the one above.
| @@ -1656,3 +1659,85 @@ impl Sequence { | |||
| handle | |||
| } | |||
| } | |||
|
|
|||
| /// Used to capture values passed to mocked methods, so you can assert on them later. | |||
There was a problem hiding this comment.
What sorts of limitations does Captor have? Like, does it work with non-'static arguments? Does it work with static methods? Does it require the arguments to be Copy or Clone?
| } | ||
|
|
||
| /// Create a new captor. See the documentation for [Captor](Captor) | ||
| pub fn captor<T>() -> Captor<T> { |
There was a problem hiding this comment.
For constructors, I prefer Captor::new, or even Captor::default.
|
|
||
| impl<T: Clone> Captor<T> { | ||
| /// Retrieve the list of all captured values, in chronological order | ||
| pub fn values(&self) -> Vec<T> { |
There was a problem hiding this comment.
Why clone the inner vec, instead of just returning a slice?
| } | ||
|
|
||
| /// Retrieve the last captured value, if any. | ||
| pub fn last_value(&self) -> Option<T> { |
There was a problem hiding this comment.
Same here. You could eliminate the clone.
| self.lock().clear() | ||
| } | ||
|
|
||
| /// Start capturing values. See the documentation for [Captor](Captor) |
There was a problem hiding this comment.
| /// Start capturing values. See the documentation for [Captor](Captor) | |
| /// Start capturing values. See the documentation for [`Captor`]. |
|
|
||
| impl<T: Clone> Captor<T> { | ||
| /// Retrieve the list of all captured values, in chronological order | ||
| pub fn values(&self) -> Vec<T> { |
There was a problem hiding this comment.
You could eliminate a clone by returning a MutexGuard instead. Maybe something like this:
| pub fn values(&self) -> Vec<T> { | |
| pub fn values(&self) -> impl Deref<Target = [T]> { | |
| self.lock() |
| } | ||
|
|
||
| /// Start capturing values. See the documentation for [Captor](Captor) | ||
| pub fn capture_values(&self) -> impl Predicate<T> { |
There was a problem hiding this comment.
Just in the interest of reducing typing, I suggest shortening the name:
| pub fn capture_values(&self) -> impl Predicate<T> { | |
| pub fn capture(&self) -> impl Predicate<T> { |
| impl<T: Clone> Predicate<T> for Captor<T> { | ||
| fn eval(&self, variable: &T) -> bool { | ||
| self.values.lock().unwrap().push(variable.clone()); | ||
| true |
There was a problem hiding this comment.
Instead of always evaluating true, would it be possible to chain Captor with another predicate?
Fixes #366