Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enforcement of warnings as errors #279

Open
SpaceIm opened this issue Jan 21, 2024 · 0 comments
Open

Remove enforcement of warnings as errors #279

SpaceIm opened this issue Jan 21, 2024 · 0 comments

Comments

@SpaceIm
Copy link

SpaceIm commented Jan 21, 2024

Could you revert #211 please? It's terrible for package managers to force warnings as errors. Warnings as errors is for library developers, not for users of your library.

There is already an option to enable Warnings as errors, why would you want to prevent someone disabling this option?

I would also advise to not hardcode all these warnings. You could add an option to enable them, beccause again these warnings are for you, users don't care and it can be harmful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant