Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on the future of the HTTP stack and plan out changes #1027

Open
jrozner opened this issue Jan 1, 2024 · 1 comment
Open

Decide on the future of the HTTP stack and plan out changes #1027

jrozner opened this issue Jan 1, 2024 · 1 comment

Comments

@jrozner
Copy link
Member

jrozner commented Jan 1, 2024

We moved away from Gorilla mux to Chi after Gorilla went EOL. It's now back from the dead and we still use a few Gorilla libs (sessions, secure cookie, etc.) Go 1.22 is going to bring a proper router to the std library. We should make a decision about the router that we want to use. It might be nice to remove another dependency and move over to the std library to avoid breakage in the future or having to deal with this again if Gorilla or Chi goes EOL. There are also issues with upgrading secrecookie #1025 and gorilla session #997. After looking this this, the implementation seems really complex with the codecs. It would be nice to simplify this.

I believe right now we're using encrypted cookies to store all the session information locally. There's probably no reason we can't switch this over to server side session storage to simplify this. We may need to update the deployment scripts and docs to enable sticky sessions.

@jrozner
Copy link
Member Author

jrozner commented Mar 17, 2024

#1025 and #997 were both fixed. There is probably still value in some simplification and making this choice but in the mean time we're in a good enough state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant