Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint scripts for local and CI #961

Merged
merged 3 commits into from May 26, 2021
Merged

fix: lint scripts for local and CI #961

merged 3 commits into from May 26, 2021

Conversation

jthegedus
Copy link
Contributor

Summary

Revert changes to local workflows from #956

  • script for Shellcheck to run locally and in CI
  • script for Shfmt to run locally and in CI
  • update release docs to reflect new pre-release workflow

@Stratus3D
Copy link
Member

Thanks for the PR @jthegedus !

@Stratus3D
Copy link
Member

I work with a lot of different projects so having a scripts directory with scripts helps remind me what I need to do before creating a PR on GitHub.

@jthegedus
Copy link
Contributor Author

jthegedus commented May 26, 2021

Fair enough. I tend to rely on the CI more myself, or githooks if available. Still, would likely need these scripts for githooks!

@jthegedus jthegedus merged commit 5dafbc8 into asdf-vm:master May 26, 2021
@jthegedus jthegedus deleted the fix/lint-script branch May 26, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants