Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove banned process substitution & force PR base branch merge #948

Closed
2 tasks done
jthegedus opened this issue May 20, 2021 · 2 comments
Closed
2 tasks done

Remove banned process substitution & force PR base branch merge #948

jthegedus opened this issue May 20, 2021 · 2 comments
Labels

Comments

@jthegedus
Copy link
Contributor

jthegedus commented May 20, 2021

Describe the bug

Process substitution was banned in #863 but I merged #881 first which included a process substitution. This was not caught because we do not require PRs to be update with master before merge.

To Reproduce

Reported: a7d3661#r51098840

Code:

} < <((printf '\0%s\0%d\0' "$( ( ( ({

Expected behavior

  • no process substitution
  • PRs should be required to be up to date with master
@jthegedus jthegedus added the bug label May 20, 2021
@jthegedus jthegedus changed the title Remove banned process substitution Remove banned process substitution & force PR base branch merge May 20, 2021
@jthegedus
Copy link
Contributor Author

I have added the branch protection rule to enforce branches are synced with master before merging:

Before & After Images

asdf-branch-protection-before

asdf-branch-protections-after

We can disable this if it becomes a nuisance.

@Stratus3D
Copy link
Member

Closing this as I have merged a PR to remove the process substitution code from the list-all command. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants