Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for plugin-update functionality. #947

Open
Stratus3D opened this issue May 20, 2021 · 1 comment
Open

Improve tests for plugin-update functionality. #947

Stratus3D opened this issue May 20, 2021 · 1 comment
Labels
enhancement

Comments

@Stratus3D
Copy link
Member

Describe the bug

When making changes to the plugin-update code for #863 a change was introduced to the find command that caused it not to find any plugin dirs. As a result the plugin-update command didn't update plugins. Our existing tests failed to catch this.

Expected behavior

Our unit tests should have caught the issue with the plugin-update command and failed when it broke.
@Stratus3D Stratus3D added the bug label May 20, 2021
@Stratus3D Stratus3D mentioned this issue May 20, 2021
Merged
@Stratus3D Stratus3D added enhancement and removed bug labels May 20, 2021
@jthegedus
Copy link
Contributor

jthegedus commented May 20, 2021 •
edited

See this comment #863 (review) for the scenario we wish to capture.

Additionally, see #1010 where the test helpers broke the plugin update tests

@hyperupcall hyperupcall mentioned this issue Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Improve asdf update experience fox-forks/asdf
2 participants
@Stratus3D @jthegedus