New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't detect latest version for plugins that use a "v" #849
Comments
Can confirm for For now, @particledecay's option 2 would be most expedient for an immediate fix, but it would be nice to see some discussion around handling version numbers more robustly to prevent this kind of issue in the future. I'm not sure exactly what that would look like, as I'm not confident there's some universal versioning scheme that will work for all plugins (e.g. as @particledecay pointed out, cases where a tool doesn't follow SemVer). But I feel like a more robust solution would be nice. |
I also have this problem with azctx / asdf-azctx. For now, I used |
I worked around this for now in my asdf plugins by simply removing the "v" for tools that I know include it: https://github.com/particledecay/asdf-kconf/blob/master/bin/list-all#L20 |
Was not aware of |
workaround for asdf-vm/asdf#849
#763 (OPs 3rd suggestion) is the direction we want to take to resolve this. |
I believe this was resolved in #938 which added |
Describe the bug
For plugins that list their versions with a leading "v", the
latest
command will return nothing by default. This means when you runplugin-test
(such as in CI) against a plugin, it will always fail.To Reproduce
Steps to reproduce the behavior:
asdf plugin-test <that_plugin>
.Expected behavior
The latest version will be displayed from the provided versions returned from the
list-all
command.Actual behavior
Nothing is displayed.
Environment
❯ asdf info OS: Linux joebeast 5.10.4-051004-generic #202012301142 SMP Wed Dec 30 11:44:55 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux SHELL: fish, version 3.1.0 ASDF VERSION: v0.8.0-f55fca4 ASDF ENVIRONMENT VARIABLES: ASDF INSTALLED PLUGINS: helm git@github.com:Antiarchitect/asdf-helm.git kconf git@github.com:particledecay/asdf-kconf.git kubectl git@github.com:Banno/asdf-kubectl.git terraform git@github.com:Banno/asdf-hashicorp.git
asdf plugins affected (if relevant):
Screenshots
Additional context
I think there are a few options:
v?
to the regex for the plugin-test command.bin/latest
orbin/latest-stable
or something).The text was updated successfully, but these errors were encountered: