fix: keep_download condition #1721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdie0
force-pushed
the
fix/keep_download
branch
from
c340e7d
to
736f49d
Compare
Birdie0
force-pushed
the
fix/keep_download
branch
from
736f49d
to
4bb5473
Compare
Birdie0
force-pushed
the
fix/keep_download
branch
from
4bb5473
to
947f19b
Compare
|
Thanks - I'll take a look at this soon. I made the original PR and want things to pass the additional test cases I added in an offline branch |
improve condition readability
|
@hyperupcall Any luck? |
|
@Birdie0 Unfortunately, I can no longer boot up the computer that had those test cases. Until I am able to diagnose and fix it, I won't be able to check. But your changes look good to me and if anything, is likely to be more correct than the existing logic anyways. I don't think my personal issues is blocking your PR. I'm not a maintainer or anything, but these days it seems more difficult to get PRs in, which is why this is isn't already merged yet, and why I have closed many of my existing PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Swap directory and argument checks so it won't result in misleading warning.
Fixes: #1711
Other Information
Also replacedInverted condition for better readability.[ ! a = b ]with[ a != b ]as it's more readable.