fix: updating references to legacy github.io site #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While clicking on a few links to test for including in our Ruby on Rails community survey resultsand noticed that the links to the previous URLs like https://asdf-vm.github.io/asdf/plugins/create.html were resulting in a 301 Redirect to http://asdf-vm.com/plugins/create.html, which would show a "Not Secure" warning in the browser.
I went ahead and updated all these references to just go directly to https://asdf-vm.com/...
Fixes: No existing issues found for this
Other Information
You might want to look at your legacy github.io site redirect logic, too, so that external links get sent to the SSL site, too.