fix: add asdf to list of banned commands #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ban recusive asdf calls as they are inefficient and may introduce bugs. If you find yourself needing to invoke an `asdf` command from within asdf code, please source the appropriate file and invoke the corresponding function.
Stratus3D
force-pushed
the
tb/ban-asdf-command-internally
branch
from
035572f
to
b6a8581
Compare
Stratus3D
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ban recusive asdf calls as they are inefficient and may introduce bugs.
If you find yourself needing to invoke an
asdfcommand from withinasdf code, please source the appropriate file and invoke the
corresponding function.
Since #1208 has been merged we can now ban internal asdf commands.