Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: making fish setup match other shells #1209

Merged
merged 1 commit into from Apr 21, 2022
Merged

Conversation

sjml
Copy link
Contributor

@sjml sjml commented Apr 20, 2022

Summary

The asdf.sh file only sets ASDF_DIR if it hasn't already been set. This change to the fish file has it do the same.

@sjml sjml requested a review from a team as a code owner April 20, 2022 16:53
@sjml
Copy link
Contributor Author

sjml commented Apr 20, 2022

I'm not entirely clear on what needs to be done to pass that lint check... please advise!

@Stratus3D
Copy link
Member

Thanks for the PR @sjml ! The changes here look good to me.

To fix the lint check you'll need to follow the commit message formatting documented here - https://www.conventionalcommits.org/en/v1.0.0/

For your commit I'd recommend amending it to:

fix: make fish shell setup match other shells

The asdf.sh file only sets `ASDF_DIR` if it hasn't already been set. This change to the fish file has it do the same.

Let me know if you need any help amending it.

The asdf.sh file only sets `ASDF_DIR` if it hasn't already been set. This change to the fish file has it do the same.
@sjml
Copy link
Contributor Author

sjml commented Apr 21, 2022

Let me know if you need any help amending it.

@Stratus3D I amended the commit message but I guess it also wants the PR title to change?

@sjml sjml changed the title Making fish setup match other shells fix: making fish setup match other shells Apr 21, 2022
@Stratus3D Stratus3D merged commit 6fc4bb8 into asdf-vm:master Apr 21, 2022
@Stratus3D
Copy link
Member

Thanks for the update @sjml ! PR merged!

@sjml sjml deleted the patch-1 branch April 21, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants