fix: remove comments from whole file instead of line by line for performance #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blopker
changed the title
blopker
force-pushed
the
feature/feature/comment-parse
branch
from
2c0858f
to
e0d8d1e
Compare
|
This is excellent @blopker ! |
Stratus3D
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change uses 1 call to
sedfor the whole.tool-versionsfile instead of for each line. This can substantially speed up file parsing if there are many comments in a file. I also had an issue with the current root.tool-verisonsfile not installingbatscorrectly because of the leadingv.Fixes: List issue numbers here
This fixes issue #1195.
Changes:
.tool-versionsat once instead of line by line for performancevfrom the root.tool-versionsfile to help asdf resolve it correctly.