feat: upgrade elvish to 0.17.0

[brunoroque06]

Summary

With version 0.17 of elvish some new syntax was introduced (https://elv.sh/blog/0.17.0-release-notes.html). The one we currently use is deprecated, and will be removed in version 0.18. I just ran the official upgrader script (https://github.com/elves/upgrade-scripts-for-0.17) on the Elvish code.

[cherryblossom000]

This isn't related to the Elvish v0.17.0 upgrade but fn asdf [@args]{_asdf:asdf $@args} in the installation docs could be replaced with var asdf~ = $_asdf:asdf~. A bit out of scope for this PR though.

[Stratus3D]

Sorry for the late review @brunoroque06, thanks for the PR!

I think @cherryblossom000 has some great comments that should be addressed. Otherwise looks good to me!

[brunoroque06]

This isn't related to the Elvish v0.17.0 upgrade but fn asdf [@args]{_asdf:asdf $@args} in the installation docs could be replaced with var asdf~ = $_asdf:asdf~. A bit out of scope for this PR though.

I changed this as well. I don't think we need to delay this to another commit. What do you think?

[cherryblossom000]

I changed this as well. I don't think we need to delay this to another commit. What do you think?

LGTM!

Also, as no one seems to have mentioned it yet, this PR is technically a breaking change as it will drop support for Elvish versions prior to v0.17.0.

[cherryblossom000]

Sorry, I just noticed the legacy assignment syntax in the tests

[cherryblossom000]

LGTM!

[Stratus3D]

Thanks for the PR @brunoroque06 !