fix: Prevent unbound variable error with nounset in asdf.sh #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehorsnell
changed the title
joehorsnell
changed the title
joehorsnell
changed the title
joehorsnell
changed the title
`asdf` [v0.9.0][1] included a [bug fix][2] to not override an existing ASDF_DIR. However, if `ASDF_DIR` is not set at all, then this causes an error when using bash `set -u`, or `set -o nounset` - see [here][3] for additional info. [1]: https://github.com/asdf-vm/asdf/releases/tag/v0.9.0 [2]: asdf-vm#1008 [3]: https://mywiki.wooledge.org/BashFAQ/112
joehorsnell
force-pushed
the
prevent_nounset_errors
branch
from
6297d7d
to
7427245
Compare
|
Sorry for the late review here @joehorsnell ! As a general rule we require issues to be reported prior to contributing a fix. However I see that this a fairly trivial one-line fix, so assuming tests pass I will go ahead and merge it. Thanks for the contributing the fix and the tests to prevent a regression! |
Stratus3D
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asdfv0.9.0 included a bug fix to not override an existingASDF_DIR.However, if
ASDF_DIRis not set at all, then this causes an error when using bashset -u, orset -o nounset- see here for additional info.asdf.sh: line 6: ASDF_DIR: unbound variableEdit: see also #160 and #817