fix: Ban ls command
#1141
Merged
fix: Ban ls command
#1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
commented
Dec 28, 2021
| @@ -454,7 +454,7 @@ resolve_symlink() { | |||
| # This seems to be the only cross-platform way to resolve symlink paths to | |||
| # the real file path. | |||
| # shellcheck disable=SC2012 | |||
| resolved_path=$(ls -l "$symlink" | sed -e 's|.*-> \(.*\)|\1|') | |||
| resolved_path=$(ls -l "$symlink" | sed -e 's|.*-> \(.*\)|\1|') # asdf_allow: ls ' | |||
There was a problem hiding this comment.
I've not yet found a better cross-platform solution to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lsshould be banned because it's seldom the right tool for the job. Often plain old shell globbing, orfindare more reliable ways of listing directories.lscommandlswithfindRelated: #1100 #1029
Fixes: Uncertain whether this will fix any outstanding issues.