Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: case-insensitive filtering of unstable versions in latest #1139

Merged
merged 2 commits into from Dec 29, 2021

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Dec 26, 2021

Summary

The asdf latest command currently only filters unstable versions with lowercase version suffixes (alpha, pre, snapshot, etc.) but fails if there are version suffixes using uppercase.

This is currently happening with the asdf-kcctl plugin.

@joschi joschi requested a review from a team as a code owner December 26, 2021 14:11
@joschi joschi changed the title Case-insensitive filtering of unstable versions in latest feat: case-insensitive filtering of unstable versions in latest Dec 26, 2021
Copy link
Member

@Stratus3D Stratus3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I don't see any harm in merging this.

@Stratus3D
Copy link
Member

Thanks for the tests!

@Stratus3D Stratus3D merged commit e61e3d9 into asdf-vm:master Dec 29, 2021
@joschi joschi deleted the latest-version-ignore-case branch December 29, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants