Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latest --all correctly report plugins as missing #1118

Merged
merged 2 commits into from Dec 9, 2021

Conversation

threkk
Copy link
Contributor

@threkk threkk commented Dec 8, 2021

Summary

Fixes the bug reported at #1096. Uninstalled plug-ins are now marked as missing. The plug-in will be marked as installed only if the latest version is among the installed plug-ins.

Fixes: #1096

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally, works as expected. Thanks

@jthegedus jthegedus changed the title fix: asdf latest --all correctly report uninstalled plugins as missing fix: latest --all correctly report plugins as missing Dec 9, 2021
@jthegedus jthegedus merged commit aafe1e5 into asdf-vm:master Dec 9, 2021
@threkk
Copy link
Contributor Author

threkk commented Dec 9, 2021

Thank you very much for catching the bug! I didn't test carefully enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants