fix: ban grep long flags #1117
Merged
fix: ban grep long flags #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1109
|
I will fix the linter errors and merge tomorrow. |
|
It was just a semantic-pr lint issue. PRs with a single commit have their commit used as the merge name, not the PR title. So the commit must match the semantic-pr naming convention or have more than one commit which means GIttHub will then use the PR title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1109
Rather than just having one array of both literal commands and regex patterns, I split the banned commands into two arrays - one of literal commands and one of regex. This allows us to use the
-E(extended regex) option when looking for banned commands via regex.