Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: newline after error msg for ASDF_DIR #1113

Merged
merged 2 commits into from Dec 6, 2021
Merged

fix: newline after error msg for ASDF_DIR #1113

merged 2 commits into from Dec 6, 2021

Conversation

mstruebing
Copy link
Contributor

Summary

Before:
Screenshot 2021-12-06 at 09 33 47

After:
Screenshot 2021-12-06 at 09 34 07

Fixes: #1112

Other Information

@mstruebing mstruebing requested a review from a team as a code owner December 6, 2021 08:46
jthegedus
jthegedus approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @mstruebing

@jthegedus
Copy link
Contributor

Please follow #1103 for Homebrew 0.9.0 update issues

@jthegedus jthegedus changed the title fix: add finalnewline to error message fix: newline after error msg for ASDF_DIR Dec 6, 2021
@jthegedus jthegedus merged commit ac2791e into asdf-vm:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: missing final newline after error message about missing $ASDF_DIR
2 participants
@mstruebing @jthegedus