Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorthand grep options for alpine support #1106

Merged
merged 3 commits into from Dec 5, 2021

Conversation

jthure
Copy link
Contributor

@jthure jthure commented Dec 5, 2021

Summary

The version of grep that is shipped with alpine doesn't seem to support "long name" options

Fixes: List issue numbers here

Other Information

@jthure jthure requested a review from a team as a code owner December 5, 2021 00:24
@jthegedus jthegedus changed the title Changed grep options to be Alpine compliant fix: shorthand grep options for alpine support Dec 5, 2021
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. editing to fix the "semantic PR" check which requires single-commit PRs to have semantic commit msgs as well. By adding a 2nd commit the check will rely on the PR title instead of the commit msg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants