Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not print find errors #1102

Merged
merged 1 commit into from Dec 5, 2021
Merged

fix: do not print find errors #1102

merged 1 commit into from Dec 5, 2021

Conversation

nozaq
Copy link
Contributor

@nozaq nozaq commented Dec 4, 2021

Summary

Do not print errors find command produces when no lib/commands exists under plugin directories.

Fixes: #1101

Other Information

Example output from asdf help on the current master branch.

...

RESOURCES
GitHub: https://github.com/asdf-vm/asdf
Docs:   https://asdf-vm.com
find: ‘/home/_/.asdf/plugins/deno/lib/commands’: No such file or directory

PLUGIN direnv
  asdf direnv
  asdf direnv hook asdf
find: ‘/home/_/.asdf/plugins/nodejs/lib/commands’: No such file or directory
find: ‘/home/_/.asdf/plugins/python/lib/commands’: No such file or directory
find: ‘/home/_/.asdf/plugins/ruby/lib/commands’: No such file or directory
find: ‘/home/_/.asdf/plugins/terraform/lib/commands’: No such file or directory

"Late but latest"
-- Rajinikanth

After applying this fix.

...

RESOURCES
GitHub: https://github.com/asdf-vm/asdf
Docs:   https://asdf-vm.com

PLUGIN direnv
  asdf direnv
  asdf direnv hook asdf

"Late but latest"
-- Rajinikanth

@nozaq nozaq requested a review from a team as a code owner December 4, 2021 10:09
@nozaq
Copy link
Contributor Author

nozaq commented Dec 5, 2021

Just pushed a fix for shfmt check.

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching.

@jthegedus jthegedus merged commit 5992abb into asdf-vm:master Dec 5, 2021
@nozaq nozaq deleted the fix-find-errs branch December 5, 2021 08:24
@jthegedus jthegedus added this to the v0.10.0 milestone Dec 5, 2021
@pre pre mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: asdf help produces errors for plugins without extension commands
2 participants