New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(latest): adds the flag --all to the latest command #1096
Conversation
As discussed in asdf-vm#1036, this patch adds a `--all` flag to the latest command which will show the list of plugins, their latest version and if this one is installed or not. This patch basically reuses the logic used in the list command and the latest command. The main different is the removal of the query paramenter as different plugins might need different queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @threkk
@threkk this has a bug. When a plugin is installed, but no versions installed, this prints "installed". EG:
Are you able to update a fix with additional test cases for the permutations? |
Hi! I am sorry for this, I will look into it ASAP. You can expect a patch this week. |
No worries mate 😄 We should also document this new flag in the |
Fixes the bug reported at asdf-vm#1096.
Fixes the bug reported at asdf-vm#1096.
Hi! The issue has been fixed at #1118 :) |
Summary
As discussed in #1036, this patch adds a
--all
flag to the latest command which will show the list of plugins, their latest version and if this one is installed or not.Fixes: #1036
Other Information
This patch basically reuses the logic used in the list command and the latest command. The main different is the removal of the query parameter as different plugins might need different queries.