Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(latest): adds the flag --all to the latest command #1096

Merged
merged 1 commit into from Dec 5, 2021

Conversation

threkk
Copy link
Contributor

@threkk threkk commented Nov 16, 2021

Summary

As discussed in #1036, this patch adds a --all flag to the latest command which will show the list of plugins, their latest version and if this one is installed or not.

Fixes: #1036

Other Information

This patch basically reuses the logic used in the list command and the latest command. The main different is the removal of the query parameter as different plugins might need different queries.

As discussed in asdf-vm#1036, this patch adds a `--all` flag to the latest
command which will show the list of plugins, their latest version and if
this one is installed or not.

This patch basically reuses the logic used in the list command and the
latest command. The main different is the removal of the query
paramenter as different plugins might need different queries.
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @threkk

@jthegedus jthegedus merged commit f85fef5 into asdf-vm:master Dec 5, 2021
@jthegedus jthegedus added this to the v0.10.0 milestone Dec 5, 2021
@jthegedus
Copy link
Contributor

@threkk this has a bug. When a plugin is installed, but no versions installed, this prints "installed". EG:

~/projects 
❯ asdf latest --all
deno    1.16.4  installed
firebase        9.23.0  installed
gcloud  365.0.1 installed
nodejs  17.2.0  installed
rust    1.57.0  installed

~/projects took 5s 
❯ asdf list gcloud
  No versions installed

Are you able to update a fix with additional test cases for the permutations?

@threkk
Copy link
Contributor Author

threkk commented Dec 5, 2021

Hi! I am sorry for this, I will look into it ASAP. You can expect a patch this week.

@jthegedus
Copy link
Contributor

Hi! I am sorry for this, I will look into it ASAP. You can expect a patch this week.

No worries mate 😄 We should also document this new flag in the help.txt.

threkk added a commit to threkk/asdf that referenced this pull request Dec 8, 2021
threkk added a commit to threkk/asdf that referenced this pull request Dec 8, 2021
@threkk
Copy link
Contributor Author

threkk commented Dec 8, 2021

Hi! The issue has been fixed at #1118 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asdf list could return the latest version available vs what's installed locally
2 participants