feat: add post update plugin support #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
reviewed
Sep 23, 2021
Stratus3D
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
These changes look good to me. @jthegedus what do you think?
|
Yes, this looks good. A very useful hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, asdf does not have a hook that is called when a plugin is updated, so it is not possible for plugins to perform migrations.
For example, if a plugin has a problem and needs to be fixed under "installs", the only way to do this is to have the user do it after installation.
With the post-install-hook, it will be possible to migrate when updating, which will make it easier to develop plug-ins and improve the usability for users.
Other Information
This may also answer the request of #859 .