fix: help for extension commands for plugins with hyphens in the name. #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacchi
force-pushed
the
fix-help-for-extension-command
branch
2 times, most recently
from
9804f12
to
a7164b2
Compare
yacchi
force-pushed
the
fix-help-for-extension-command
branch
from
a7164b2
to
798f918
Compare
yacchi
changed the title
|
Thanks for the PR @yacchi ! And thanks for writing a test! It looks like the linter is failing for these changes so we'll have to get that fixed before we merge. |
Stratus3D
approved these changes
Sep 23, 2021
|
Not sure why it was saying checks failed before and now it's saying all have passed. I'm going to go ahead and merge this. Thanks for contributing this fix! |
|
@Stratus3D At the time I created the pull request, the git commit message and pull request name did not comply with Lint's rules. While I was looking for a way to rerun CI tasks, it seemed that all CI tasks on Github had gone green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a plugin with a hyphen in its name contains an extension command (lib/commands/commands-*), the - in the plugin name displayed by asdf help will be blank.
Fixes: #1034