Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect usage of grep #1035

Merged
merged 1 commit into from Sep 2, 2021

Conversation

yacchi
Copy link
Contributor

@yacchi yacchi commented Sep 2, 2021

Summary

Message displayed when executing a command that does not specify a version, and the error message is output at the same time because of incorrect usage of grep.

Extract from macOS man:

-F, --fixed-strings
Interpret pattern as a set of fixed strings (i.e. force grep to behave as fgrep).
-f file, --file=file
Read one or more newline separated patterns from file. Empty pattern lines match every input line. Newlines are not considered part of a pattern. If file is empty, nothing is matched.

Expected:

> go
No version set for command go
Consider adding one of the following versions in your config file at 
go-sdk 1.17

Actual(in head branch):

> go
grep: go-sdk 1.17
go-sdk system: No such file or directory
No version set for command go
Consider adding one of the following versions in your config file at 
go-sdk 1.17

@yacchi yacchi requested a review from a team as a code owner September 2, 2021 16:23
@Stratus3D Stratus3D merged commit 30d27cb into asdf-vm:master Sep 2, 2021
@Stratus3D
Copy link
Member

Thanks for the PR @yacchi !

@yacchi yacchi deleted the fix-incorrect-usage-of-grep branch September 3, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants