Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle off repo sync completely #1011

Merged
merged 8 commits into from Aug 3, 2021
Merged

feat: toggle off repo sync completely #1011

merged 8 commits into from Aug 3, 2021

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Jul 25, 2021

Summary

This builds on #957 by allowing the plugin shortname repo sync to be toggled off completely with:

# $HOME/.asdfrc
plugin_repository_last_check_duration = never

Fixes: #978

Other Information

Docs changes comparison

image

@jthegedus jthegedus requested a review from a team as a code owner July 25, 2021 09:07
@jthegedus
Copy link
Contributor Author

jthegedus commented Jul 25, 2021

I am still not happy with the docs for these. I will propose another change tomorrow.

I think the tables make each of the valid values and their affect more clear, especially in the case of plugin_repository_last_check_duration where we now have 3 different settings.

@jthegedus jthegedus self-assigned this Jul 26, 2021
@jthegedus jthegedus requested a review from Stratus3D July 26, 2021 22:57
@Stratus3D
Copy link
Member

Sorry for the late review. Looking at this now.

| Options | Description |
| :--------------------------------------------------------- | :----------------------------------------- |
| `no` <Badge type="tip" text="default" vertical="middle" /> | Delete source code or binary after install |
| `yes` | Keep source code or binary after install |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tables seem a little unnecessary for some of these options.

Also, this:

Delete source code or binary after install

Should be:

Delete source code or binary after successful install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tables seem a little unnecessary for some of these options.

I found the the plugin_repository_last_check_duration very wordy and unclear without the table. After adding one it seemed best to be consistent, though I agree the binary settings don't benefit all that much.

@jthegedus jthegedus merged commit a3ba5a7 into asdf-vm:master Aug 3, 2021
@jthegedus jthegedus deleted the feat/repo-sync-never branch August 3, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: toggle off plugin repo sync
2 participants