New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle off repo sync completely #1011
Conversation
I think the tables make each of the valid values and their affect more clear, especially in the case of |
Sorry for the late review. Looking at this now. |
docs/manage/configuration.md
Outdated
| Options | Description | | ||
| :--------------------------------------------------------- | :----------------------------------------- | | ||
| `no` <Badge type="tip" text="default" vertical="middle" /> | Delete source code or binary after install | | ||
| `yes` | Keep source code or binary after install | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tables seem a little unnecessary for some of these options.
Also, this:
Delete source code or binary after install
Should be:
Delete source code or binary after successful install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tables seem a little unnecessary for some of these options.
I found the the plugin_repository_last_check_duration
very wordy and unclear without the table. After adding one it seemed best to be consistent, though I agree the binary settings don't benefit all that much.
Summary
This builds on #957 by allowing the plugin shortname repo sync to be toggled off completely with:
Fixes: #978
Other Information
Docs changes comparison