Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor subcommand methods to use named args (too long method signature) #111

Open
ptrpfn opened this issue Feb 2, 2022 · 0 comments
Open

Comments

@ptrpfn
Copy link
Collaborator

ptrpfn commented Feb 2, 2022

via @jwaggs in PR 109 and 110:

our subcommands are getting pretty bloated - it will likely be worth it to refactor them into better bite sized chunks at some point. But until then, it might be good to use keyword args instead of positional args. In general if there are more than 2 or 3 parameters I like to shift to using keyword args.

Example from commands.py:

def verify_entire_folder(
    root_path, verbose, packing_list_path, ignore_list=None, ignore_spec_file=None, calculate_only=None
):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant