Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping when no wrapping is wanted. (the fixing of .columns.wrap did that) #456

Open
xrayn opened this issue Oct 4, 2021 · 0 comments
Open

Comments

@xrayn
Copy link

xrayn commented Oct 4, 2021

I'll give a counter example that questions the fix provided for #353 (comment)

= Grid Wrapping Tests
:imagesdir: images/
// reveal.js config
:revealjs_hash: true
:revealjs_center: false
:revealjs_height: 1080
:revealjs_width: 1920

[.columns.wrap]
== Shouldn't Wrap But Does

[.column]
* Things here should not wrap
* But they do, thanks to flex-basis: auto;

[.column]
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
[.column]
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.

The expected behavior for me is do not wrap, simply because in my opinion the default behavior should be that when specifying 3 columns, then every column should have one-third of the space and the content auf each column should be adapted, i.e. shrinked or whatever, (as best as possible) to meet that requirement.

The use-case of #353 (comment) was not well suited to demonstrate or show a invalid behavior. I mean, what do you expect, when you say, I want three columns, but provide 2 images that fill over 90% (900 + 900 = 1800) of the screen (1920), leaving only 120 pixel for the first column.

Now, if a columns is "full", for some reason, the flex-basis: auto; forces a wrap and no longer tries to modify the content such that it may fit.

At least for me, this "fix" broke dozens of slides that needed the content to be adapted to fit in a column.

I'm not saying that the old behavior was correct (although it was for me :) ). But I'm asking the question, which behavior is considered valid in this case. Because ther cannot be a solution for both variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant