Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background hides quoted code blocks #1620

Closed
Bonjour123 opened this issue May 10, 2024 · 4 comments
Closed

White background hides quoted code blocks #1620

Bonjour123 opened this issue May 10, 2024 · 4 comments
Assignees
Labels

Comments

@Bonjour123
Copy link

Bonjour123 commented May 10, 2024

Observed vs. expected behavior

In webstorm, I get annoying background when using these code quotes: "`".
They overlap the quotes and appear only in asciidoc editor. It seems I can't control neither the color nor the behavior in the intelliJ settings .
I get this issue for any theme and color scheme combination.
Modifying the asciidoc color scheme entries and setting a black background doesn't help, as after a few milliseconds after each keypress, the white background appears again.
So I think this behavior is neither derived from a theme nor a color scheme, I think it's shipped within the plugin.

The problem is that when using a dark color scheme, the background color becomes almost white, and I can't see the text.
As a workaround, I can modify asciidoc color scheme and set the foreground text to black.

But then:

  1. I still get some unreadable text (depends on the color scheme settings, since this whitish background is not from the color scheme).
  2. My editor is full of big white rectangles that really are not helpful highlighting, as code-wrapped text is not that important
  3. All the white rectangles flicker at every single key press

Steps to reproduce

Any adoc containing code quotes "`" works.

Shows the unreadable and flickery rectangles as well as the color scheme where no background is set

weird_background_adoc_webstorm_light_theme_dark_color.webm

Before

Screenshot from 2024-05-10 12-28-10

After setting foreground to black in asciidoc color scheme

Screenshot from 2024-05-10 12-29-18

Environment

Plugin Version: 0.41.14

IntelliJ Details: WebStorm 2023.3.3
Build #WS-233.14015.89, built on January 23, 2024
Runtime version: 17.0.9+7-b1087.11 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 6.5.0-28-generic
GC: G1 Young Generation, G1 Old Generation
Memory: 3938M
Cores: 16
Registry:
debugger.new.tool.window.layout=true
run.configuration.max.name.length=180
ide.experimental.ui=true
eslint.additional.file.extensions=svelte
run.anything.context.recent.directory.number=15
Non-Bundled Plugins:
de.netnexus.camelcaseplugin (3.0.12)
com.intellij.properties (233.11799.172)
dev.meanmail.plugin.nginx-intellij-plugin (2022.1.1)
XPathView (233.11799.188)
com.intellij.aqua (233.14015.147)
org.asciidoctor.intellij.asciidoc (0.41.14)
de.timo_reymann.intellij-mjml-support (3.3.0)
dev.blachut.svelte.lang (233.14015.23)
Current Desktop: ubuntu:GNOME

@Bonjour123 Bonjour123 added the bug label May 10, 2024
@ahus1
Copy link
Contributor

ahus1 commented May 20, 2024

Thank you for reporting this. I managed to reproduce something similar to your video when I used a light theme with the VibraInk Editor theme. Did you consider a "Dark" theme when using the "VirbraInk" Editor color theme?

Here's the screenshot of the settings I have tested when I didn't have problems in the editor:

image

Can you please share your settings in that dialog "Appearance & Behavior" -> "Appearance"?

@Bonjour123
Copy link
Author

Yes, I actually shifted to the Dark theme from the Light one. No problems with the dark themes, but only with the light ones.
->Just re-read my issue, I actually thought that it was working well with dark themes, so don't know why I wrote I get this issue for any theme and color scheme combination.... maybe I forgot to save the edits..

Unfortunately I had to reinstall my os for another unrelated problem, so I currently have default settings in Webstorm.

@ahus1 ahus1 self-assigned this May 20, 2024
@ahus1
Copy link
Contributor

ahus1 commented May 20, 2024

I found that the AsciIDoc plugin picked the background color or the light theme where it should have picked the color of the dark theme as some function was looking for the theme of the IDE and not the editor.

This will be fixed in the next release of the plugin, and I'll post a note here once a preview version is available.

In the meantime, when using a dark theme for the editor, use it with a dark theme of the IDE.

@ahus1 ahus1 closed this as completed May 20, 2024
ahus1 added a commit that referenced this issue May 20, 2024
@Bonjour123
Copy link
Author

Great to hear ! Thank you for the awesome work !

ahus1 added a commit that referenced this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants