Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use 4.0 in precompiled script plugin #711

Open
vpavic opened this issue Jan 23, 2024 · 6 comments
Open

Unable to use 4.0 in precompiled script plugin #711

vpavic opened this issue Jan 23, 2024 · 6 comments
Milestone

Comments

@vpavic
Copy link

vpavic commented Jan 23, 2024

We're using org.asciidoctor:asciidoctor-gradle-jvm-pdf in a (very simple) precompiled script plugin written in Kotlin.

After attempting to upgrade the plugin to 4.0.1 the build fails with the following error:

$ ./gradlew asciidoctorPdf

> Task :plugins:compileKotlin FAILED
e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class org.asciidoctor.gradle.jvm.pdf.AsciidoctorPdfTask, unresolved supertypes: org.asciidoctor.gradle.jvm.AbstractAsciidoctorTask
    class org.asciidoctor.gradle.jvm.pdf.AsciidoctorPdfThemesExtension, unresolved supertypes: org.asciidoctor.gradle.base.AbstractDownloadableComponent
Adding -Xextended-compiler-checks argument might provide additional information.

This setup works fine with 3.3.2.

Here's a simple reproducer:
sample-asciidoctor-pdf.zip

@ysb33r
Copy link
Member

ysb33r commented Jan 26, 2024

QQ: If you asciidoctor-gradle-jvm to your dependencies in the included build, do you still see the same problem?

@vpavic
Copy link
Author

vpavic commented Jan 26, 2024

That indeed helps, thanks.

Having taken a closer look at the project build now, shouldn't api configuration be used here (instead of implementation):

implementation project(':asciidoctor-gradle-jvm')

@ysb33r ysb33r added this to the 4.0 milestone Jan 26, 2024
@ysb33r
Copy link
Member

ysb33r commented Jan 26, 2024

Thanks for confirming. It has been changed for the 4.0.2 release, which hopefully should out before end of Jan '24.

I am going to close this out.

@ysb33r ysb33r closed this as completed Jan 26, 2024
@vpavic
Copy link
Author

vpavic commented Feb 3, 2024

This situation is still the same with 4.0.2, could you please re-open this?

Looking at the published POMs here, org.asciidoctor:asciidoctor-gradle-jvm dependency is still declared with the runtime scope (vs compile as it was pre-4.0).

I can see that 82d2a2b changed the dependency configuration, but that change isn't present on master.

@vpavic
Copy link
Author

vpavic commented Feb 14, 2024

Any feedback here @ysb33r?

@ysb33r ysb33r reopened this Feb 15, 2024
@ysb33r
Copy link
Member

ysb33r commented Feb 15, 2024

I haven't had a chance to look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants