Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision number, date and remark are not rendered #460

Open
OlivierJourdan opened this issue Dec 10, 2020 · 4 comments
Open

revision number, date and remark are not rendered #460

OlivierJourdan opened this issue Dec 10, 2020 · 4 comments

Comments

@OlivierJourdan
Copy link

OlivierJourdan commented Dec 10, 2020

It seems that document revision is not rendered (tested with Chrome).
Same document rendered with Asciidoctor toolchain display information fine.

@ggrossetie
Copy link
Member

That's correct.
This is a duplicate of #122 and as mentioned by Dan:

The author and revision info doesn't currently show in embeddable output, which is what Chrome is showing.

Though, using the embeddable output is an implementation detail and I think we should provide an option to display (or not) these information.

Related issues:

I like the idea of negating the noheader attribute (which we can imply is set by default when converting to embeddable HTML).

@mojavelinux Do you still stand behind this statement? Can we implement this logic in the browser extension to control if we should output the author, date, and revision info?

@OlivierJourdan
Copy link
Author

Ok, thank you for the explanation (sorry for the duplicate).

@mojavelinux
Copy link
Member

Can we implement this logic in the browser extension to control if we should output the author, date, and revision info?

I think that's perfectly acceptable. After all, this is a rendering decision. I don't think we should try to make the configuration as intuitive as possible, though. Since so many people expect it, maybe we should just match what the standalone output is doing.

@ggrossetie
Copy link
Member

Since so many people expect it, maybe we should just match what the standalone output is doing.

Negating noheader is a bit weird so if we decide that showing the complete header (with revision number, date and remark) is the default that would be even simpler.
We can then mention in the documentation that it's possible to use noheader to hide the revision number, date and remark. Combined with notitle you can hide the header completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants