Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add simple ADSR editor #410

Open
quirkylemon opened this issue Jan 20, 2024 · 0 comments
Open

Proposal: add simple ADSR editor #410

quirkylemon opened this issue Jan 20, 2024 · 0 comments

Comments

@quirkylemon
Copy link

The current envelope generator is pretty intimidating for first time users so I propose that we add an option to use a simple ADSR envelope generator

this would just change how it is displayed.

  1. the attack knob will just affect EG rate 1
  2. the decay knob will just affect EG rate 3
  3. the sustain knob will just affect EG level 3
  4. the release knob will just affect EG rate 4

one issue is what to do when switching from the advanced EG to the simple EG.
2 potential options are:

  1. pretend like nothing happened and just keep the knob positions even if the simple adsr editor can't change them.
  2. give you a warning that you need to confirm then set the incompatible knobs to the default value (potentially saving them for if you revert back to the advanced EG)

I would be happy to implement everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant