Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module path is not versioned in go.mod #496

Open
devcharmander opened this issue Jan 8, 2024 · 0 comments
Open

Module path is not versioned in go.mod #496

devcharmander opened this issue Jan 8, 2024 · 0 comments

Comments

@devcharmander
Copy link

BC Break Report

This package is not versioned in the go.mod

Q A
Version v11.0.1

Summary

When I do a get on this package, I get errors indicating that the go.mod had non v11 module path.
This also results in other side effects for teams that have rennovate bot in their workflow.'

For example:

- github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect
+ github.com/asaskevich/govalidator/v11 v11.0.1 // indirect

This will not work as the module path doesn't have v11 suffix

Expected behavior

go get gopkg.in/asaskevich/govalidator v11.0.1 and go get gopkg.in/asaskevich/govalidator.v11 should work

Current behavior

go get gopkg.in/asaskevich/govalidator.v11                                                                                  
go: gopkg.in/asaskevich/govalidator.v11@v11.0.1: invalid version: go.mod has non-....v11 module path "github.com/asaskevich/govalidator" at revision v11.0.1

go get gopkg.in/asaskevich/govalidator v11.0.1                                                                                 
go: gopkg.in/asaskevich/govalidator: unrecognized import path "gopkg.in": parse https://gopkg.in/?go-get=1: no go-import meta tags ()
go: unrecognized import path "v11.0.1": https fetch: Get "https://v11.0.1/?go-get=1": dial tcp: lookup v11.0.1: no such host

How to reproduce

Run either of these commands

go get gopkg.in/asaskevich/govalidator v11.0.1   
go get gopkg.in/asaskevich/govalidator v11.0.1   

Is there a reason for not versioning the module path ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant