Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't smoothing of discrete variables be optional in plot_bpv, especially when using kind=t_stat? #2325

Open
lciti opened this issue Mar 14, 2024 · 2 comments

Comments

@lciti
Copy link

lciti commented Mar 14, 2024

Describe the bug

Discrete data passed to plot_bpv are always smoothed:

obs_vals, pp_vals = smooth_data(obs_vals, pp_vals)

I wonder if this should be made optional (possibly default True), at least in the case of kind='t_stat' where one may want to design a custom t_stat function that deals with the discrete data in a particular way. Having the data "smoothed" makes it hard to work with in this case.

@lciti lciti changed the title Shouldn't smoothing of discrete variables be optional in plotpbv, especially when using kind=t_stat? Shouldn't smoothing of discrete variables be optional in plot_bpv, especially when using kind=t_stat? Mar 14, 2024
@aloctavodia
Copy link
Contributor

Hi, yes. This makes sense.

@Patchouli-Kenntnis
Copy link

This makes sense, but can you give me a small example dataset to show the difference of smoothing / without smoothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants