Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of numba opt-in not opt-out #2313

Open
ricardoV94 opened this issue Feb 21, 2024 · 3 comments
Open

Make use of numba opt-in not opt-out #2313

ricardoV94 opened this issue Feb 21, 2024 · 3 comments

Comments

@ricardoV94
Copy link

Calling forest_plot when numba is installed ends up with cryptic errors: ValueError: Failed in object mode pipeline (step: remove phis nodes) This is a PITA.

Please consider making the use of numba opt-in (not simply by having numba installed).

@tomicapretto
Copy link
Contributor

If we wanted to do this, I think (almost?) everything is already there. We just need to make sure that

if Numba.numba_flag:

is not True by default when numba is installed (which is the case now)

@OriolAbril
Copy link
Member

Sounds good to me, the only change would be in

numba_flag = numba_check()
make it False instead of the result of numba_check.

I'll also look into the error, it might not change much between using numba there or not if its in object mode.

@drbenvincent
Copy link
Contributor

+1: I'm hitting this error as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants