Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wheels for 3.12 #7650

Open
NatanSlvdr opened this issue Mar 13, 2024 · 5 comments
Open

Python wheels for 3.12 #7650

NatanSlvdr opened this issue Mar 13, 2024 · 5 comments

Comments

@NatanSlvdr
Copy link

In the 2.0.10 release, some commits are about building for python 3.12, but there are no wheels on PyPi.

Is it normal ?

@arvidn
Copy link
Owner

arvidn commented Apr 6, 2024

The github workflow for building and publishing the wheel has not been working for a while.
I triggered a build for 2.0.10 here: https://github.com/arvidn/libtorrent/actions/runs/8579717727

@NatanSlvdr
Copy link
Author

NatanSlvdr commented Apr 15, 2024 via email

@DjLegolas
Copy link

It seem that there is an issue with the cibuildwheel action on the 2.0.10 release.
@arvidn you have pushed some changes to it only in 4ef2211 (which still fail on windows)

@qstokkink
Copy link

I tried to reconstruct the action run failure. I think what is happening is this (matching the log output):

  1. The pypa/cibuildwheel@v2.12.3 is used (see here).
  2. The default value of '' is used for the only input of the cibuildwheel action (see here).
  3. Specifically for Windows, --only '"${{ inputs.only }}"' is used, which evaluates to --only '""' (see here).
  4. The cibuildwheel application then parses the only command-line value as "", i.e., not empty (see here).
  5. The cibuildwheel application tries to match "" to a known platform, which fails and causes the log statement Invalid --only='""', must be a build selector with a known platform (see here).

From the linked source code of (4), it seems that the only way out of this situation is to omit the argument only (to the application). However, this seems impossible due to the forced double-quotes of (3) in the pypa/cibuildwheel@v2.12.3 action. Thankfully, this seems to be recently fixed and it should just be a matter of switching to pypa/cibuildwheel@v2.17.0.

I hope that helps resolve this issue.

@arvidn
Copy link
Owner

arvidn commented May 11, 2024

#7672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants