Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Gradle plugin Android Variant aware. #59

Open
3 tasks
arunkumar9t2 opened this issue Jun 20, 2020 · 0 comments
Open
3 tasks

Make Gradle plugin Android Variant aware. #59

arunkumar9t2 opened this issue Jun 20, 2020 · 0 comments
Labels
enhancement New feature or request module:gradle-plugin Label to mark all discussions about gradle plugin
Projects
Scabbard Development

Comments

@arunkumar9t2
Copy link
Owner

arunkumar9t2 commented Jun 20, 2020 •
edited

Currently the gradle plugin is not Android aware and adds processor to app level instead of variant level. Should consider making it such that it is variant aware and only adds scabbard to debug build types.

  • Add dependency on AGP
  • Change application logic to only consider variant.buildType = 'debug.
  • Consider providing a variantFilter DSL like Keeper does.
@arunkumar9t2 arunkumar9t2 added enhancement New feature or request module:gradle-plugin Label to mark all discussions about gradle plugin labels Jun 20, 2020
@arunkumar9t2 arunkumar9t2 added this to the 0.5.0 milestone Jun 20, 2020
@arunkumar9t2 arunkumar9t2 removed this from the 0.5.0 milestone Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module:gradle-plugin Label to mark all discussions about gradle plugin
Projects
Scabbard Development
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arunkumar9t2