Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails #1

Closed
Jojo144 opened this issue Dec 30, 2017 · 2 comments
Closed

Installation fails #1

Jojo144 opened this issue Dec 30, 2017 · 2 comments

Comments

@Jojo144
Copy link

Jojo144 commented Dec 30, 2017

It would be very good to have such a package!
I could help but my knowings in yunohost and django are very limited.

I tried to install it on a VM, and I encountered the following issues:

  1. My version of Yunohost was not recent enough (need >= 2.6.4 for one of the helpers)

  2. The command ynh_install_app_dependencies python3 virtualenv git fails with "Invalid control file"
    (I temporarily manually installed the dependencies and commented this line)

  3. Te command source "${venv}/bin/activate" fails with "Warning: /var/www/my_djangoapp/env/bin/activate: line 8: _OLD_VIRTUAL_PATH: unbound variable"
    I can fix it with something like

set +o nounset
. ~/.env/bin/activate
set -o nounset

(taken here pypa/virtualenv#150)

  1. The command django admin ... fails with "Warning: CommandError: Destination directory '/var/www/my_djangoapp/app' does not exist, please create it first."
    I fixed it adding some mkdirs.

  2. Then it got stuck on the creation of the django superuser.

I tried your las commit 299fe50 (with my temorary fixes) but it fails with "WARNING ./install: line 104: setup_django: command not found".

@artus40
Copy link
Owner

artus40 commented Jan 3, 2018

Thanks for your interest !
I know little myself and actually learn on the way :)

You've realized i think it is a work in progress, i actually didn't even run it in a VM yet. I'm testing django related scripts on my desktop computer for now.
Still, the 4. and 5. should be resolved by my last commits.

Regarding 1., i copied an old manifest.json file from my_webapp_ynh a while back, it would be better to just get the new version but i didn't get to that since i can't test it yet anyway.
I dont understand 2. at all, maybe the answers are inside ynh_install_app_dependencies declaration ?

Finally, 3. thanks for this great tip !
I'm not sure about my design though, is it necessary to activate/deactivate inside all venv related functions or is it better to just use the binaries full paths ?

Anyway, thanks again for your help ! Feel free to contribute, i'm also new to collaboration with git, but will gladly learn how to manage some pull requests :)

artus40 pushed a commit that referenced this issue Jan 3, 2018
@artus40
Copy link
Owner

artus40 commented Oct 10, 2018

I found time to make some huge progress. It is still work-in-progress but should be much easier to test out.
The package.py script should help to build a brand new Yunohost app from any locally-working django project.

I've been testing it inside a VM and installation now completes !

@artus40 artus40 closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants