Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VM/vm] don't completely eliminate unsupported functions #1597

Open
github-actions bot opened this issue Mar 15, 2024 · 0 comments
Open

[VM/vm] don't completely eliminate unsupported functions #1597

github-actions bot opened this issue Mar 15, 2024 · 0 comments
Labels
enhancement New feature or request error handling Issues related to Error handling library Issues related to the standard library todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation

Comments

@github-actions
Copy link

[VM/vm] don't completely eliminate unsupported functions
right now, if we have e.g. a MINI build, some - albeit few -
features are disabled. As a consequence, some functions cannot
work. For example, mysqlite is not available in MINI builds.
However, totally removing e.g. open - leads to confusing
situations, such as me using the function and all I can see
is that the identifier... "open" wasn't found.
Not very helpful at all, given that we could simply let people
know what is going on. That would obviously mean not completely
eliminating the function, only having it throw an error in case
some - or all - of its features are not supported.
Also, it would be a good idea to create sth like a macro(?) which
could combine the logic of when defined(MINI) (or whatever) +
the error handling part. Food for thought! ;-)

# TODO(VM/vm) don't completely eliminate unsupported functions

#=======================================

# TODO(VM/vm) don't completely eliminate unsupported functions
#  right now, if we have e.g. a MINI build, some - albeit few -
#  features are disabled. As a consequence, some functions cannot
#  work. For example, mysqlite is not available in MINI builds.
#  However, totally removing e.g. `open` - leads to confusing
#  situations, such as me using the function and all I can see
#  is that the identifier... "open" wasn't found.
#  Not very helpful at all, given that we could simply let people
#  know what is going on. That would obviously mean *not* completely
#  eliminating the function, only having it throw an error in case
#  some - or all - of its features are not supported.
#  Also, it would be a good idea to create sth like a macro(?) which
#  could combine the logic of `when defined(MINI)` (or whatever) +
#  the error handling part. Food for thought! ;-)
#  labels: vm, library, error handling, enhancement

importLib "Arithmetic"
importLib "Bitwise"
importLib "Collections"
ndex 8f92474c37..5f6322925a 100644
++ b/version/build

7f6e7e4ec497a5c403006daa327d9160cbdbd5d6

@github-actions github-actions bot added enhancement New feature or request error handling Issues related to Error handling library Issues related to the standard library todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request error handling Issues related to Error handling library Issues related to the standard library todo Automatically generated issues from TODOs in the code vm Issues related to the Virtual Machine implementation
Projects
None yet
Development

No branches or pull requests

0 participants