-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to disable/enable the webhook while rendering Operator #57
Comments
Hi @dashanji can you please provide sample operator manifest along with actual and expected helmify output? it will help to write e2e test and fix the issue. |
Okay, In fact, we developed an operator using |
@arttor Hi, are you working on this? If possible, I can help add the feature. |
@dashanji yes, you can create PR or help with the proposal.
The problem with this approach is that it is hard to define which volume is related to the webhook and which is not. Will it work if we will just disable |
If we only disable the |
If the goal is to simply disable webhook validation for CRD, then we can just disable webhook and leave volume, claim, service, and stuff. You can try to disable the default volume in deployment but it will require a lot of effort. |
@dashanji thank you for your contribution! #97 is merged and available in v0.3.34 release. Should we close this issue? |
I'm sorry not now. Actually, #97 is to add the cert-manager as a subchart rather than enable/disable the webhook. I'm still working on it and will ping you if finished. WDUT? |
Hi @arttor, the relevant pr is ready, could you please take a look? |
Hi, there, could we provide a flag to add a judgment in
webhooks
and relevant resources(service, volume, etc) while rendering Operator built bykubebuilder
?The text was updated successfully, but these errors were encountered: