Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart.Appversion not as a default usable since image.tag set in values.yaml #15

Open
batistein opened this issue Dec 2, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@batistein
Copy link

Thank you for this amazing project.

When generating the charts, the image tag is also set in values.yaml. In the deployment itself, the default is set correctly (.Chart.Appversion) , but it can not be used by default since the image tag is set in the values.yaml. Especially with the combination of helmify with helmfile where values are only overwritten this is a little bit disturbing.

@arttor
Copy link
Owner

arttor commented Dec 4, 2021

Thank you for the feedback!

Totally agree that Appversion should be a default value for the image tag of the main container.
But it is difficult to identify the main container if there are several sidecars in a pod.

I was thinking that people will use helmify to generate boilerplate and will do some polishing afterward.
In this case, it is better to have all stuff in values.yaml, and users will remove redundant params.

I can see several options:

  • always remove image tag from values.yaml
  • remove image tag from values.yaml if pod has 1 container
  • remove image tag from values.yaml if it has "latest" value
  • remove image tag from values.yaml if its value equals to Appversion

What do you think?

@arttor arttor added enhancement New feature or request help wanted Extra attention is needed labels Nov 26, 2022
@giautm
Copy link

giautm commented Aug 23, 2023

Hello @arttor, I running into the same issue. We need to remove the tag from image, but there is no option to do that.

I prefer to the option always remove image tag from values.yaml, but we can avoid BC with --no-image-tag in the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants