You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When generating the charts, the image tag is also set in values.yaml. In the deployment itself, the default is set correctly (.Chart.Appversion) , but it can not be used by default since the image tag is set in the values.yaml. Especially with the combination of helmify with helmfile where values are only overwritten this is a little bit disturbing.
The text was updated successfully, but these errors were encountered:
Totally agree that Appversion should be a default value for the image tag of the main container.
But it is difficult to identify the main container if there are several sidecars in a pod.
I was thinking that people will use helmify to generate boilerplate and will do some polishing afterward.
In this case, it is better to have all stuff in values.yaml, and users will remove redundant params.
I can see several options:
always remove image tag from values.yaml
remove image tag from values.yaml if pod has 1 container
remove image tag from values.yaml if it has "latest" value
remove image tag from values.yaml if its value equals to Appversion
Thank you for this amazing project.
When generating the charts, the image tag is also set in values.yaml. In the deployment itself, the default is set correctly (.Chart.Appversion) , but it can not be used by default since the image tag is set in the values.yaml. Especially with the combination of helmify with helmfile where values are only overwritten this is a little bit disturbing.
The text was updated successfully, but these errors were encountered: