Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one ouput template-file is generated #118

Open
o4rz3l opened this issue Jul 26, 2023 · 3 comments
Open

Only one ouput template-file is generated #118

o4rz3l opened this issue Jul 26, 2023 · 3 comments

Comments

@o4rz3l
Copy link

o4rz3l commented Jul 26, 2023

Hi!
i have the following issue. I'm pipeing the following into helmify via
oc process -f template.yaml -o yaml | yq '.items[] | split_doc' | helmify
oc is a CLI for working with Openshift Cluster. The ouput before helmify is the following:

apiVersion: apps.openshift.io/v1
kind: DeploymentConfig
... 
---
apiVersion: v1
kind: Service
...
---
apiVersion: route.openshift.io/v1
kind: Route
...

I expected, that the chart would have three files, one per resource, but i only get one with all three in it.
Is this intended or is there some error in my approach?

Thanks a lot for help!

@arttor
Copy link
Owner

arttor commented Aug 11, 2023

hi, helmify often groups the same kinds in a single file. Not sure if it was a good decision. But if resulted charts contain all templates it is not a bug. We can introduce a new flag to forcibly create a new file for each manifest. What do you think?

@o4rz3l
Copy link
Author

o4rz3l commented Aug 28, 2023

Hi @arttor, thanks for your reply! Hm, yes, i think that would be a good idea, because it would give me/others the change to have one file for a resource. In my point of view a much better visibility of the resources in a Chart.

@rgarrigue
Copy link

Hello. Agreed with OP. I'd add that some tools like pre-commit's check-yaml complain about more than one resource / file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants