feat: additional printer attributes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sergio-P Could you please rebase your branch? I downgraded the Node version in TravisCI to 17, it should fix the build issue. I will review your PR, thanks for contributing. |
Sergio-P
force-pushed
the
master
branch
2 times, most recently
from
092a3cd
to
29f81b0
Compare
prettier fix
|
I have rebased my branch and fixed some issues spotted in Travis. Now all checks have passed |
artiebits
changed the title
|
thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some use cases it will be convenient to have more attributes about the printers, such as the status, alerts and connection. These are fetched directly from the
lpstat -lpcommand so it is not necessary to make additional execs.This PR adds the mentioned attributes to the Printer object.