fix: fix parsing for non-english systems #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue:
The
getPrinters
method is returning an empty array, because the parser is searching forprinter
but on systems with different system languages will it be for exampleDrucker
and don't will match for anything.The same issue will be in the mapping of additional information.
Solution:
Force console output of the
lpstat -lp
command to english to make the parsing work on non-english systems.German systems is currently showing this result:
With the prefix will it be forced to english: